#5 Rewrite the mysql class

Open
opened 4 years ago by spaghetti · 2 comments

Should probably just extend mysqli instead of being a wrapper

Definitely needs to start exposing methods for prepared statements

Should probably just extend mysqli instead of being a wrapper Definitely needs to start exposing methods for prepared statements
spaghetti added the
Breaking
label 4 years ago
spaghetti added the
Enhancement
label 4 years ago
spaghetti added the
Migrated Issue
label 4 years ago
spaghetti commented 4 years ago
Owner

This will almost definitely be a breaking change, and large parts of gazelle will need to be modified to use the new class.

Current plan is to write a new class completely while leaving the old class in tact for legacy purposes, and steadily migrating all uses of the old class to the new one. This way we don’t have to deal with writing a class backwards compatible with the old class.

This will almost definitely be a breaking change, and large parts of gazelle will need to be modified to use the new class. Current plan is to write a new class completely while leaving the old class in tact for legacy purposes, and steadily migrating all uses of the old class to the new one. This way we don't have to deal with writing a class backwards compatible with the old class.
spaghetti commented 4 years ago
Owner

Using some nice syntactical features of PHP7, we’ve added prepared statement support to the current database class in a backwards compatible way, and are now slowly migrating existing queries.

Using some nice syntactical features of PHP7, we've added prepared statement support to the current database class in a backwards compatible way, and are now slowly migrating existing queries.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.